Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double slashes in GitHub pages link on Windows #3810

Closed
tobymurray opened this issue Dec 31, 2016 · 3 comments
Closed

Double slashes in GitHub pages link on Windows #3810

tobymurray opened this issue Dec 31, 2016 · 3 comments
Labels
P5 The team acknowledges the request but does not plan to address it, it remains open for discussion type: bug/fix

Comments

@tobymurray
Copy link

tobymurray commented Dec 31, 2016

OS?

Windows 10

Versions.

λ ng --version
angular-cli: 1.0.0-beta.24
node: 7.2.1
os: win32 x64
@angular/common: 2.4.1
@angular/compiler: 2.4.1
@angular/core: 2.4.1
@angular/forms: 2.4.1
@angular/http: 2.4.1
@angular/platform-browser: 2.4.1
@angular/platform-browser-dynamic: 2.4.1
@angular/router: 3.4.1
@angular/compiler-cli: 2.4.1

Repro steps.

λ ng new test-app
...
λ cd test-app
λ ng github-pages:deploy
Hash: 2bf0e1245eb5e01382d8
Time: 26858ms
chunk    {0} main.1c717b9fe8fd3d6882ab.bundle.js, main.1c717b9fe8fd3d6882ab.bundle.map (main) 2.91 MB {2} [initial] [rendered]
chunk    {1} styles.87416f5cb43dddfee231.bundle.css, styles.87416f5cb43dddfee231.bundle.map, styles.87416f5cb43dddfee231.bundle.map (styles) 1.69 kB {2} [initial] [rendered]
chunk    {2} inline.f4b4f29a7e700f2413a5.bundle.js, inline.f4b4f29a7e700f2413a5.bundle.map (inline) 0 bytes [entry] [rendered]
Deployed! Visit https://tobymurray.github.io//test-app//
Github pages might take a few minutes to show the deployed site.

The issue here (I believe) is the the double forward slashes in the URL. Very minor, mostly cosmetic as the browser still resolves double slashes appropriately in this case but looks like its unintentional. I tried this out in both Cmder (ConEmu) and Windows Command Prompt and it yielded the same message.

@icepeng
Copy link

icepeng commented Jan 2, 2017

Same here

@filipesilva filipesilva added command: deploy P5 The team acknowledges the request but does not plan to address it, it remains open for discussion type: bug/fix labels Jan 24, 2017
@filipesilva
Copy link
Contributor

Closed via #4385.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P5 The team acknowledges the request but does not plan to address it, it remains open for discussion type: bug/fix
Projects
None yet
Development

No branches or pull requests

3 participants