Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ng github-page:deploy not generating files with hashes, only main.bundle.js #4048

Closed
rxjs-space opened this issue Jan 16, 2017 · 4 comments
Closed
Assignees
Labels
P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful type: bug/fix

Comments

@rxjs-space
Copy link

Please provide us with the following information:

OS?

Windows10.

Versions.

Please run ng --version. If there's nothing outputted, please run in a Terminal: node --version and paste the result here:
angular-cli: local (v1.0.0-beta.25.5, branch: master)
node: 6.5.0
os: win32 x64
@angular/common: 2.4.3
@angular/compiler: 2.4.3
@angular/core: 2.4.3
@angular/forms: 2.4.3
@angular/http: 2.4.3
@angular/platform-browser: 2.4.3
@angular/platform-browser-dynamic: 2.4.3
@angular/router: 3.4.3
@angular/compiler-cli: 2.4.3

Repro steps.

Was this an app that wasn't created using the CLI? What change did you do on your code? etc.
My app created using ng new.

The log given by the failure.

Normally this include a stack trace and some more information.
No error.

Mention any other details that might be useful.

I can have main.addad3558a8e7df8de84.bundle.js with ng build --prod, but only main.bundle.js with ng github-paged:deploy. Even ng github-paged:deploy --prod won't give any hashes.
No such thing in v1.0.0-beta24.


Thanks! We'll be in touch soon.

@rxjs-space
Copy link
Author

rxjs-space commented Jan 16, 2017

I added outputHashing: 'bundles' after this line , and there I have the hashes. I think hashes should be default behavior for github-pages:deploy, since it's using prod mode.

@filipesilva
Copy link
Contributor

This is a bug. With the introduction of #3885, the deploy command (and test) weren't updated to also generate/verify the hashes.

@filipesilva filipesilva added type: bug/fix command: deploy P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful labels Jan 16, 2017
@filipesilva filipesilva self-assigned this Jan 16, 2017
@filipesilva
Copy link
Contributor

Closed via #4385.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful type: bug/fix
Projects
None yet
Development

No branches or pull requests

2 participants