Skip to content

--dry-run creates empty folder #4500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
niklas-dahl opened this issue Feb 7, 2017 · 3 comments
Closed

--dry-run creates empty folder #4500

niklas-dahl opened this issue Feb 7, 2017 · 3 comments

Comments

@niklas-dahl
Copy link
Contributor

OS?

Windows 7

Versions.

@angular/cli: 1.0.0-beta.30
node: 7.5.0
os: win32 x64
@angular/common: 2.4.6
@angular/compiler: 2.4.6
@angular/core: 2.4.6
@angular/forms: 2.4.6
@angular/http: 2.4.6
@angular/platform-browser: 2.4.6
@angular/platform-browser-dynamic: 2.4.6
@angular/router: 3.4.6
@angular/cli: 1.0.0-beta.30
@angular/compiler-cli: 2.4.6

Repro steps.

Was this an app that wasn't created using the CLI? What change did you do on your code? etc.

  1. ng new proj && cd proj
  2. ng g module settings3 --routing --dry-run
λ ng g module settings3 --routing --dry-run
installing module
You specified the dry-run flag, so no changes will be written.
  create src\app\settings3\settings3-routing.module.ts
  create src\app\settings3\settings3.module.ts
installing component
You specified the dry-run flag, so no changes will be written.
  create src\app\settings3\settings3.component.css
  create src\app\settings3\settings3.component.html
  create src\app\settings3\settings3.component.spec.ts
  create src\app\settings3\settings3.component.ts

Despite saying no changes will be written an empty folder src/app/settings3 is created.

Mention any other details that might be useful.

Without the routing flag no empty folder is generated.

@delasteve
Copy link
Contributor

I just attempted this with rc.0 and was not able to reproduce it.

test-app (master) » ng g module settings3 --routing --dry-run
installing module
You specified the dry-run flag, so no changes will be written.
  create src/app/settings3/settings3-routing.module.ts
  create src/app/settings3/settings3.module.ts
test-app (master) » ls src/app
app.component.css     app.component.html    app.component.spec.ts app.component.ts      app.module.ts

@niklas-dahl
Copy link
Contributor Author

from https://github.com/angular/angular-cli/blob/master/CHANGELOG.md#breaking-changes-1

1.0.0-beta.32 (2017-02-17)
...
BREAKING CHANGES
...
@angular/cli: Generating a module with routing will no longer generate an associated component.

Thats probably why..

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants