-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aot compilation succeeds without warnings or errors for bad templates #4538
Comments
Same here! In addition, file sizes generated by a build with |
I can also confirm this: I'm using a custom configuration with only the |
@hansl can you weigh in? |
Generated files were not diagnosed in AOT which led to errors not being shown properly. Also, in order to show the proper error source we now resolve the sourcemap of any errors we find. Fixes angular#5264 Fixed angular#4538
Really cool thanks for the type checking! |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Aot compilation succeeds without warnings or errors for bad templates for me. I was unable to find any documentation or hints as to why this might be. Is there any configuration I can do to get the benefits of template type checking from AOT compilation?
OS
El Capitan
Versions.
@angular/cli: 1.0.0-beta.30
node: 7.2.1
os: darwin x64
@angular/common: 2.4.6
@angular/compiler: 2.4.6
@angular/core: 2.4.6
@angular/forms: 2.4.6
@angular/http: 2.4.6
@angular/platform-browser: 2.4.6
@angular/platform-browser-dynamic: 2.4.6
@angular/router: 3.4.6
@angular/cli: 1.0.0-beta.30
@angular/compiler-cli: 2.4.6
Repro steps.
put a non existent tag such as {{invalid}} in app.component.html in the project generated by
ng new
then dong build --aot
The text was updated successfully, but these errors were encountered: