Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ng test breaks when module.id is set #4876

Closed
filipesilva opened this issue Feb 21, 2017 · 1 comment
Closed

ng test breaks when module.id is set #4876

filipesilva opened this issue Feb 21, 2017 · 1 comment
Labels
P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful type: bug/fix

Comments

@filipesilva
Copy link
Contributor

ng test will break on apps that have moduleId: module.id in the @Component metadata.

Error: moduleId should be a string in "AppComponent". See https://goo.gl/wIDDiL for more information.
If you're using Webpack you should inline the template and the styles, see https://goo.gl/X2J8zc.

This is due to ng test using a different setup of AoTplugin that does not strip module.id.
@filipesilva filipesilva added P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful type: bug/fix labels Feb 21, 2017
@filipesilva filipesilva mentioned this issue Feb 21, 2017
Closed
asnowwolf pushed a commit to asnowwolf/angular-cli that referenced this issue Apr 12, 2017
@filipesilva
feat(@angular/cli): use same webpack config for karma
1fa936c 
Close angular#4851
Fix angular#3605
Fix angular#4850
Fix angular#4876
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful type: bug/fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(@angular/cli): use shared configs for ng test filipesilva/angular-cli
1 participant
@filipesilva