-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(@angular/cli): adding help descriptions #4887
Conversation
35904c4
to
2823688
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job getting these all in!
In the future we should make the command descriptions the source of truth for the wiki docs even, similar to how the completion command uses options to auto-generate shell scripts.
I've a couple of change requests:
- Use
oneLine
(or similar, as needed) from thecommon-tags
lib for multiline descriptions instead of concatenating strings. - Start every description with a capital letter, and end it with a period.
- Remove
flag to...
(and similar) from descriptions. e.g.flag whether to build using Ahead of Time compilation
->build using Ahead of Time compilation
. I know that's how it shows up in our doc but its pretty redundant. - If you have time, propagate your new description strings back to the wiki doc.
ef03cae
to
2a7295f
Compare
@filipesilva Done the changes to make changes back to wiki will talk to @Brocco |
Awesome, thanks! |
2a7295f
to
fbf391d
Compare
00345fe
to
cda7804
Compare
cda7804
to
7ebe4f0
Compare
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Shuld Fix: #4845