fix: Enforce loglevel warn for npm-install #5010
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
The npm call uses the node exec() call which has a default limit of 200kb after which the process is terminated. When the user has set the info loglevel ng new terminates without any helpful error message. When using --quiet the loglevel is set to warning in any case resulting in a successful build. This is especially important for users of docker since the current node base image sets the loglevel to info.
|
CLAs look good, thanks! |
filipesilva
approved these changes
Feb 25, 2017
filipesilva
pushed a commit
that referenced
this pull request
Mar 3, 2017
The npm call uses the node exec() call which has a default limit of 200kb after which the process is terminated. When the user has set the info loglevel ng new terminates without any helpful error message. When using --quiet the loglevel is set to warning in any case resulting in a successful build. This is especially important for users of docker since the current node base image sets the loglevel to info. Close #5010
asnowwolf
pushed a commit
to asnowwolf/angular-cli
that referenced
this pull request
Apr 12, 2017
The npm call uses the node exec() call which has a default limit of 200kb after which the process is terminated. When the user has set the info loglevel ng new terminates without any helpful error message. When using --quiet the loglevel is set to warning in any case resulting in a successful build. This is especially important for users of docker since the current node base image sets the loglevel to info. Close angular#5010
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The npm call uses the node exec() call which has a default limit
of 200kb after which the process is terminated.
When the user has set the info loglevel ng new terminates without
any helpful error message. When using --quiet the loglevel is
set to warning in any case resulting in a successful build.
This is especially important for users of docker since the current
node base image sets the loglevel to info.