Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jasmine HTML report not displayed when code coverage enabled during test #5136

Closed
brandonroberts opened this issue Mar 1, 2017 · 5 comments
Labels
feature Issue that requests a new feature P5 The team acknowledges the request but does not plan to address it, it remains open for discussion

Comments

@brandonroberts
Copy link
Contributor

Please provide us with the following information:

OS?

Windows 7, 8 or 10. Linux (which distribution). Mac OSX (Yosemite? El Capitan?)

OSX Yosemite

Versions.

Please run ng --version. If there's nothing outputted, please run in a Terminal: node --version and paste the result here:

@angular/cli: 1.0.0-rc.0
node: 6.9.5
os: darwin x64
@angular/common: 2.4.8
@angular/compiler: 2.4.8
@angular/core: 2.4.8
@angular/forms: 2.4.8
@angular/http: 2.4.8
@angular/platform-browser: 2.4.8
@angular/platform-browser-dynamic: 2.4.8
@angular/router: 3.4.8
@angular/cli: 1.0.0-rc.0
@angular/compiler-cli: 2.4.8

Repro steps.

Was this an app that wasn't created using the CLI? What change did you do on your code? etc.

  1. Create a new application
  2. Run npm test
  3. Note test results are displayed in the karma browser window above app works!
  4. Run npm test -- --code-coverage
  5. Note test results are not displayed and app works! is displayed

The log given by the failure.

Normally this include a stack trace and some more information.

N/A

Mention any other details that might be useful.


Thanks! We'll be in touch soon.

@Zyzle
Copy link

Zyzle commented Mar 1, 2017

From what I can see this is a simple fix in the generated projects karma.conf.js but not sure if it has any other issues:

--- a/karma.conf.js
+++ b/karma.conf.js
@@ -32,7 +32,7 @@ module.exports = function (config) {
       environment: 'dev'
     },
     reporters: config.angularCli && config.angularCli.codeCoverage
-              ? ['progress', 'coverage-istanbul']
+              ? ['progress', 'coverage-istanbul', 'kjhtml']
               : ['progress', 'kjhtml'],
     port: 9876,
     colors: true,

Zyzle pushed a commit to Zyzle/angular-cli that referenced this issue Mar 1, 2017
…e report

kjhtml reporter now displays when testing with code coverage report generation

Close angular#5136
@delasteve
Copy link
Contributor

@Zyzle, I don't believe it will have any issues. Thanks for the PR!

@hansl
Copy link
Contributor

hansl commented Mar 4, 2017

I pulled the plug on this one because it's a change in the output of the CLI and will have to wait until at least 1.1. Will keep the issue open as something work on.

@hansl hansl added the feature Issue that requests a new feature label Mar 4, 2017
@brandonroberts brandonroberts changed the title Jasmine HTML report not display when code coverage enabled during test Jasmine HTML report not displayed when code coverage enabled during test Mar 4, 2017
delasteve added a commit to delasteve/angular-cli that referenced this issue Mar 20, 2017
delasteve added a commit to delasteve/angular-cli that referenced this issue Mar 20, 2017
delasteve added a commit to delasteve/angular-cli that referenced this issue Mar 20, 2017
@filipesilva filipesilva added command: test P5 The team acknowledges the request but does not plan to address it, it remains open for discussion labels Mar 20, 2017
delasteve added a commit to delasteve/angular-cli that referenced this issue May 2, 2017
delasteve added a commit to delasteve/angular-cli that referenced this issue May 4, 2017
@filipesilva
Copy link
Contributor

Fixed in #6160.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature Issue that requests a new feature P5 The team acknowledges the request but does not plan to address it, it remains open for discussion
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants