Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

root tsconfig.json breaking atom-typescript on new project #5257

Closed
scttcper opened this issue Mar 6, 2017 · 7 comments
Closed

root tsconfig.json breaking atom-typescript on new project #5257

scttcper opened this issue Mar 6, 2017 · 7 comments

Comments

@scttcper
Copy link
Contributor

scttcper commented Mar 6, 2017

Autocomplete and all inteli type features are broken in atom-typescript without the addition of an exclude in root tsconfig.json:

"exclude": ["node_modules"]

vscode seems fine. Could be related to TypeStrong/atom-typescript#1106

OSX latest - atom 1.14.4 - atom-typescript 10.1.15

@dave11mj
Copy link
Contributor

dave11mj commented Mar 6, 2017

Thanks ! I was experiencing the same issue and the exclude seems to optimize it for me! ^^

@Meligy
Copy link
Contributor

Meligy commented Mar 6, 2017

Which version are you using?

There was an issue affecting VS Code as well in RC0, and it should be fixed in new projects generated by RC1, thanks to #5060 changes.

@dave11mj
Copy link
Contributor

dave11mj commented Mar 6, 2017

I am using the following versions:

OS X El Capitan version 10.11.6
Angular Cli 1.0.0-rc.0
Atom 1.14.4
atom-typescript 10.1.13

@scttcper
Copy link
Contributor Author

scttcper commented Mar 6, 2017

1.0.0-rc.1
what I have after adding the exclude

{
  "compileOnSave": false,
  "compilerOptions": {
    "outDir": "./dist/out-tsc",
    "sourceMap": true,
    "declaration": false,
    "moduleResolution": "node",
    "emitDecoratorMetadata": true,
    "experimentalDecorators": true,
    "target": "es5",
    "lib": [
      "es2016",
      "dom"
    ],
  },
  "exclude": ["node_modules"]
}

@Meligy
Copy link
Contributor

Meligy commented Mar 16, 2017

There were more changes in RC2, check again in a new project please.

@scttcper
Copy link
Contributor Author

scttcper commented Mar 16, 2017

Still not working without the exclude. Waiting for TypeStrong/atom-typescript#1166 or people can install atom-typescript-beta (deactivate atom-typescript). Not really something angular-cli needs to solve since atom-typescript is what's wrong.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants