Skip to content

TypeScript changes not deployed, even though ng serve detects the changes #5600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
etovian opened this issue Mar 23, 2017 · 9 comments
Closed
Labels
needs: repro steps We cannot reproduce the issue with the information given

Comments

@etovian
Copy link

etovian commented Mar 23, 2017

Bug Report or Feature Request (mark with an x)

- [x ] bug report -> please search issues before submitting
- [ ] feature request

Versions.

Repro steps.

  1. Make a change to a TypeScript file
  2. Observe that webpack recompiles
  3. Observe that the browser refreshes
  4. Observe that the TypeScript changes were not deployed to the browser
  5. Make a change to an html template file
  6. Observe that the html changes have been deployed to the browser, but any TypeScript changes have not

The log given by the failure.

No exceptions are thrown

Mention any other details that might be useful.

IDE: IntelliJ
OS: Windows 10

@etovian
Copy link
Author

etovian commented Mar 23, 2017

It's probably also pertinent that I'm running ng serve with the --proxy-config switch. Here's my config file:

{
"/api": {
"target": "http://localhost:8080",
"secure": false
}
}

@etovian
Copy link
Author

etovian commented Mar 23, 2017

But the problem persists, even if I run ng serve without the --proxy-config switch. In either case, if I halt ng serve and run it again, the latest TypeScript changes are deployed to the browser after it refreshes.

@trevor-hackett
Copy link

Which version of the cli are you using?

@etovian
Copy link
Author

etovian commented Mar 23, 2017

Sorry, I thought I included ng --version output in the ticket:

@angular/cli: 1.0.0-rc.4
node: 6.10.0
os: win32 x64
@angular/common: 2.4.10
@angular/compiler: 2.4.10
@angular/core: 2.4.10
@angular/forms: 2.4.10
@angular/http: 2.4.10
@angular/material: 2.0.0-beta.2
@angular/platform-browser: 2.4.10
@angular/platform-browser-dynamic: 2.4.10
@angular/router: 3.4.10
@angular/cli: 1.0.0-rc.4
@angular/compiler-cli: 2.4.10

@clydin
Copy link
Member

clydin commented Mar 23, 2017

This PR should hopefully address the issue: #5492

@filipesilva
Copy link
Contributor

@etovian are you saying that neither TS or HTML changes are reflected in the browser? I can't reproduce that, I see changes appearing in the browser. Do you always get this?

@filipesilva filipesilva added the needs: repro steps We cannot reproduce the issue with the information given label Mar 24, 2017
@hansl
Copy link
Contributor

hansl commented Mar 24, 2017

This should have been fixed by #5492.

@hansl hansl closed this as completed Mar 24, 2017
@etovian
Copy link
Author

etovian commented Mar 24, 2017

@filipesilva HTML was working fine. I was just demonstrating that the problem was limited to TypeScript. @hansl What version will the #5492 fix release in? Thanks!

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs: repro steps We cannot reproduce the issue with the information given
Projects
None yet
Development

No branches or pull requests

5 participants