Skip to content

Display typescript version being used during ng build --progress and/or ng build --verbose #6627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fmorriso opened this issue Jun 9, 2017 · 7 comments · Fixed by #7372
Closed
Assignees
Labels
feature Issue that requests a new feature help wanted P5 The team acknowledges the request but does not plan to address it, it remains open for discussion severity2: inconvenient

Comments

@fmorriso
Copy link

fmorriso commented Jun 9, 2017

Bug Report or Feature Request (mark with an x)

- [ ] bug report -> please search issues before submitting
- [x ] feature request

Versions.

Output from: ng --version.
@angular/cli: 1.1.1
node: 7.10.0
os: win32 x64

Repro steps.

ng build --progress --verbose

The log given by the failure.

Desired functionality.

What would like to see implemented?
Display the version of TypeScript used during ng build if the --progress option is specified.
Background:
Currently, when ng build --progress is invoked, we see the version of webpack used, as shown in this example:
Version: webpack 2.4.1
Please include the version of TypeScript used during builds when the --progress (or should it be --verbose?) switch is specified.

Mention any other details that might be useful.

@Brocco Brocco added P5 The team acknowledges the request but does not plan to address it, it remains open for discussion severity2: inconvenient help wanted labels Jun 13, 2017
@Brocco Brocco self-assigned this Jun 13, 2017
@Brocco Brocco added the feature Issue that requests a new feature label Jun 13, 2017
@bniedermeyer
Copy link
Contributor

Is this necessary given the potential work to implement it? To me it doesn't seem too inconvenient for someone to check the version of TypeScript or any other library they're using in package.json. You aren't usually hot-swapping versions during the development of a project.

If it is decided to be worth it I'd be happy to do a PR for this, but I'd like a little bit of guidance first. It seems that the code currently is just outputting the webpack stats returned from the compiler, and the typescript version is not included in the Stats model.

It doesn't seem too difficult to output an additional line with the TypeScript version from package.json, but I'm hesitant to add in one line just to output a one-off piece of data. Is there a better place this logic could live? Perhaps the addition of a new --libraries option that would display the versions of all libraries in the project's package.json?

@fmorriso
Copy link
Author

Echoing out the version of the most important tool used to build Angular applications, TypeScript, during the build process, for those who wish to see it (via --libraries, --verbose or similar option) may not be the highest priority, but I would like to see it scheduled, at whatever priority is deemed appropriate.

@hansl hansl assigned hansl and unassigned Brocco Aug 4, 2017
@hansl
Copy link
Contributor

hansl commented Aug 4, 2017

We will rescope this issue to show the typescript version on ng version. I agree with the general sentiment here that having that information on build isn't really useful (and if you serve or watch will never change between builds).

@fmorriso
Copy link
Author

fmorriso commented Aug 5, 2017

Using ng version is good for displaying the globally installed edition of TypeScript, but it might not be the best choice for showing which version of TypeScript was used during a build of a specific Angular project.

Think about what information is requested when someone submits a new issue. Wouldn't the relevant version of TypeScript be the one emitted during the ng build process, not the one emitted by the ng version process?

@bniedermeyer
Copy link
Contributor

@fmorriso I see where you're coming from. Luckily ng --version already has a precedence for differentiating between global and local versions of what's installed on a project. For example I ran ng --version on a project running version 1.0.0 of the cli and this is what's output.

image

Handling Typescript in a similar fashion wouldn't be too jarring from a user experience perspective and people are asked to include the output from ng --version during issue submission anyway so the TypeScript info will be there for users experiencing problems.

@tfonji
Copy link
Contributor

tfonji commented Aug 7, 2017

@hansl can you please assign this to me? I would like to submit a PR and complete the task as discussed, showing the version of typescript when the command ng version is used.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature Issue that requests a new feature help wanted P5 The team acknowledges the request but does not plan to address it, it remains open for discussion severity2: inconvenient
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants