Skip to content

Add "defaultSeverity": "warning" to tslint.json when scaffolding app #7185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
EvAlex opened this issue Jul 28, 2017 · 3 comments
Closed

Add "defaultSeverity": "warning" to tslint.json when scaffolding app #7185

EvAlex opened this issue Jul 28, 2017 · 3 comments

Comments

@EvAlex
Copy link

EvAlex commented Jul 28, 2017

Bug Report or Feature Request (mark with an x)

- [x] bug report -> please search issues before submitting
- [ ] feature request

Versions.

@angular/cli: 1.2.1
node: 7.10.0
os: win32 x64
Windows 10

Repro steps.

  1. Create an app: ng new tempApp
  2. Open any .ts file, e.g. src/main.ts
  3. Make any change that will break tslint rules, e.g. remove semicolon at the end of any line.
  4. Run ng lint
  5. You get ERROR: "path to main.ts"[line, col]: Missing semicolon

The log given by the failure.

ERROR: C:/Users/Alexander/tempApp/src/main.ts[11, 52]: Missing semicolon

Lint errors found in the listed files.

Desired functionality.

Default severity for broken tslint rules should be warning. Those red underlines make me feel that I made error, but in fact I just missed some tiny thing. This sometimes is very disturbing. I think, that syntax error or wrong type, missing member etc. error - are real errors, but tslint errors should be warnings by default.

Mention any other details that might be useful.

@EvAlex EvAlex changed the title Add "defaultSeverity": "warning" to tslint.json when scaffolding app Add "defaultSeverity": "warning" to tslint.json when scaffolding app Jul 28, 2017
@clydin
Copy link
Member

clydin commented Jul 28, 2017

Unfortunately, the situation has some complexity to it. Please see this PR for details.

@filipesilva
Copy link
Contributor

Closing as per @clydin's comment.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants