Update to 1.3.0-rc.5 broke my service worker (with --build-optimizer)

[mrjmd]

Bug Report or Feature Request (mark with an x)

- [x] bug report -> please search issues before submitting
- [ ] feature request

Versions.

Repro steps.

git clone git@github.com:contentacms/contenta_angular.git
cd contenta_angular
npm install
ng serve --prod --build-optimizer
Examine the dist/sw-register bundle.

The log given by the failure.

No error, just no service worker being registered any more. Inside my sw-register I see the problem, this is the entire contents:

webpackJsonp([3],{3:function(n,o,t){n.exports=t("EUKP")},EUKP:function(n,o){navigator}},[3]);

When normally it looks like this:

webpackJsonp([3],{3:function(r,e,o){r.exports=o("EUKP")},EUKP:function(r,e){"serviceWorker"in navigator&&navigator.serviceWorker.register("worker-basic.min.js").catch(function(r){console.error("Error registering service worker:",r)})}},[3]);

Mention any other details that might be useful.

I was previously running 1.3.0-rc.0 so I'm not sure which version introduced this issue, I tested 1.3.0-rc.3 as well and my dist/sw-register file looks as expected, so my guess is this was just introduced. Note the size of the sw-register bundle here using rc.3:

[clydin]

Does it work without the build optimizer enabled?

[mrjmd]

Ah, good question. I just checked, and yes, ng build --prod generates sw-register properly on 1.3.0-rc.5, so this seems to be specifically an issue with CLI 1.3.0-rc.5 when using --build-optimizer and service worker.

[mrjmd]

I can confirm this happens with a brand new app as well. New repro steps:

• ng new cli-test
• cd cli-test
• ng set apps.0.serviceWorker=true
• npm install @angular/service-worker
• ng build --prod --build-optimizer
• Examine dist/sw-register bundle

Screenshot, note the small 93 byte bundle:

File contents are:

webpackJsonp([3],{3:function(n,o,t){n.exports=t("EUKP")},EUKP:function(n,o){navigator}},[3]);

Version info:

[filipesilva]

angular/devkit#77 and a CLI release including it should fix this.