-
Notifications
You must be signed in to change notification settings - Fork 12k
ng serve stop watching changes after an error in typescript file #8022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This is unintended and I will investigate. |
:))) I thought this is a feature, I'm using angular cli 1.5 beta 4 and it have the same issue when I have 5 ERROR, If I fix some ERROR but not clear, it not rebuild, it only rebuild until I fix ALL 5 ERRORS and auto rebuild normally. |
@hiepxanh it is intended that builds fail while you have errors, but this report seems to show it will not rebuild even after the error is fixed. |
Same issue here, but whith other version @angular/cli: 1.4.5 By the way I'm using webstorm 2017.2 |
Have the same issue, very disruptive to my development time right now, and there are no leads to what may be causing this... @angular/cli: 1.4.7 Using Sublime Text |
Have this problem on two projects
Looks like new file is cached after an error - that's my guess @angular/cli: 1.4.2 and 1.4.7 |
Heya, I'm trying to reproduce using the instructions here, but I cannot see the behaviour you are reporting. This is what I did:
Anyone have an idea of what be missing in my testing? These are my versions btw:
|
Moving from @angular/* 4.4.4 to 4.4.5 seem's to fix the non recompilation after an error for me. |
I am experiencing the same behavior. I upgraded to the versions that @filipesilva posted sadly no difference. I have tested this across several clients projects we have all the same behavior. Once the build failed with webpack: Failed to compile then the watch stops. I do notice that it has to be a typescript error. I add a invalid include path in a .scss file then fix that error it will trigger a rebuild.
|
@filipesilva: I'm currently experiencing this when I get "Supplied parameters do not match any signature of call target." errors. |
I noticed this when the initial build fails. If initial build succeeds and there is an error on a subsequent build, fixing the error triggers a successful rebuild. But if there is an error on the initial build, fixing it will not trigger a rebuild. |
Getting this error as well, as @bmayen described. Annoying, since new builds from scratch can take a lot of time (26 seconds compared to incremental builds of ~1 second). Using angular-cli 1.4.9, Node 8.8.0 and command |
This bug is really strange. I can reproduce it in our codebase by inserting |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Bug Report or Feature Request (mark with an
x
)Versions.
@angular/cli: 1.4.6
node: 6.10.3
os: win32 x64
@angular/animations: 4.4.4
@angular/common: 4.4.4
@angular/compiler: 4.4.4
@angular/core: 4.4.4
@angular/forms: 4.4.4
@angular/http: 4.4.4
@angular/platform-browser: 4.4.4
@angular/platform-browser-dynamic: 4.4.4
@angular/router: 4.4.4
@angular/cli: 1.4.6
@angular/compiler-cli: 4.4.4
@angular/language-service: 4.4.4
typescript: 2.3.4
Repro steps.
Make an error in ts file.
You get a message: webpack: Failed to compile.
Get rid of the error in the code.
ng serve
does not rebuild automatically.The log given by the failure.
ERROR in events.service.ts (13,21): Cannot find name 'Routerws'.
webpack: Failed to compile.
Desired functionality.
The ng serve should detect the fixes after an error and rebuild the app like always. For now, everytime, I have an error I need to kill the process with ctr+c and retype
ng serve
again.The text was updated successfully, but these errors were encountered: