Skip to content

Report file errors on loader #8058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
filipesilva opened this issue Oct 14, 2017 · 6 comments
Closed

Report file errors on loader #8058

filipesilva opened this issue Oct 14, 2017 · 6 comments
Assignees
Labels
P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful type: bug/fix

Comments

@filipesilva
Copy link
Contributor

Currently compilation errors get reported in the entry points (polyfills.ts, main.ts) and for the compilation itself afterwards:

ERROR in ./src/polyfills.ts
Module build failed: Error: TypeScript compilation failed.
    at plugin.done.then (/Users/iminar/tmp/regression-test-project/node_modules/@angular/cli/node_modules/@ngtools/webpack/src/loader.js:479:27)
 @ multi ./src/polyfills.ts
ERROR in ./src/main.ts
Module build failed: Error: TypeScript compilation failed.
    at plugin.done.then (/Users/iminar/tmp/regression-test-project/node_modules/@angular/cli/node_modules/@ngtools/webpack/src/loader.js:479:27)
    at process._tickCallback (internal/process/next_tick.js:103:7)
 @ multi ./src/main.ts
ERROR in Error: Unexpected value 'MdIconModule in /Users/iminar/tmp/regression-test-project/node_modules/@angular/material/material.d.ts' imported by the module 'AppModule in /Users/iminar/tmp/regression-test-project/src/app/app.module.ts'. Please add a @NgModule annotation.

We should instead report errors for a given file on the file loader, and the rest of these errors in the compilation.

@filipesilva filipesilva added P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful type: bug/fix labels Oct 14, 2017
@filipesilva filipesilva self-assigned this Oct 14, 2017
@bjohnson-va
Copy link

Is there a workaround for this?

@Stradivario
Copy link

I have the same problem and it come from no where... in about 10 minutes my builds where passing and after one css change and re-build application i cannot build production no more...

@elvisbegovic
Copy link
Contributor

elvisbegovic commented Oct 27, 2017

can't work, im stressed, im scared :) , this is urgent

all my module are telling :

Module build failed: Error: C:\Users\eee\WebstormProjects\iii\src\app\societe\societe
.module.ts is not part of the compilation. Please make sure it is in your tsconfig via
the 'files' or 'include' property.
    at AngularCompilerPlugin.getCompiledFile (C:\Users\eee\WebstormProjects\iii\node_
modules\@ngtools\webpack\src\angular_compiler_plugin.js:693:23)
    at plugin.done.then (C:\Users\eee\WebstormProjects\iii\node_modules\@ngtools\webp
ack\src\loader.js:467:39)
 @ ./src/$$_lazy_route_resource lazy
 @ ./node_modules/@angular/core/esm5/core.js
 @ ./src/main.ts
 @ multi webpack-dev-server/client?http://0.0.0.0:0 ./src/main.ts

but I don't know what I need to change in my tsconfig.json and in my tsconfig.app.json

@filipesilva

@bjohnson-va
Copy link

bjohnson-va commented Oct 27, 2017

@istiti I believe you can just roll back to 1.4.7 if you need to keep working
Oh, you've got a different error. Maybe open a different issue?

@filipesilva
Copy link
Contributor Author

Fixed by #8203

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful type: bug/fix
Projects
None yet
Development

No branches or pull requests

4 participants