Skip to content

Since @ngtools/webpack is bad after 1.8, so since 1.8.1 is not working compile because of removing the decorators. #9104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
p3x-robot opened this issue Jan 5, 2018 · 3 comments

Comments

@p3x-robot
Copy link

p3x-robot commented Jan 5, 2018

Versions

Using webpack, not using ng.
Angular Material and Angular CLI (latest) and Angular all the latest (5.1.3).

Repro steps

It is written here to repro: #8525

Observed behavior

It is related to this: #8525

Desired behavior

Should not remove decorators or kindly fix it, so it works with my repro steps.
I couldn't at all create a new project of my own with this remove decorators new function in 1.8.1.

Mention any other details that might be useful (optional)

This file is in @ngtools/webpack 1.9.3 :
File: angular_compiler_plugin.ts

If I comment this code:

// Remove unneeded angular decorators.
//this._transformers.push(removeDecorators(isAppPath, getTypeChecker));

It works.
I think the removeDecorators is not working for sure.

@p3x-robot
Copy link
Author

Is there an options to keep the decorators? While is it removing something that is doing this?

@p3x-robot p3x-robot changed the title Since @ngtools/webpack is bad after 1.8, so since 1.8.1 is not working compile Since @ngtools/webpack is bad after 1.8, so since 1.8.1 is not working compile because of removing the decorators. Jan 5, 2018
@clydin
Copy link
Member

clydin commented Jan 5, 2018

Please don't open duplicate issues. It makes tracking an issue difficult. Please continue the discussion in #8525.

@clydin clydin closed this as completed Jan 5, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants