@ngtools/webpack above 1.8.0 is not working because of removing the decorators #8525
Comments
p3x-robot
changed the title
|
Ok, i confirmed, |
p3x-robot
changed the title
|
Heya, I can reproduce this issue with our tests that use the plugin by itself. Can you setup a minimal repro please? You can read here why this is needed. A good way to make a minimal repro is to create a new app app that uses the plugin with a simplified webpack config and adding the minimum possible code to show the problem. Then you can push this repository to github and link it here. |
filipesilva
added
the
needs: repro steps
|
heya!
you mean Heya, I cannot reproduce this issue with our tests that use the plugin by itself. |
|
Yes, that is what I meant. Sorry for the confusion 😞 |
|
Well, you can built it like this: git clone https://github.com/patrikx3/corifeus-builder-angular
cd corifeus-builder-angular
yarn install
yarn link
git clone https://github.com/patrikx3/corifeus-web-material
cd corifeus-web-material
yarn install
gruntWith 1.8.0 it works, with 1.8.5 is not, same error. The webpack settings are in Now if you change at I guess you still have to go to rm -rf ./node_modules
yarn installThen go to rm -rf ./node_modules
yarn install
yarn link corifeus-builder-angular
gruntNow you get the same error. Is it in the webpack that changed? Or the Here are the files the are connected to https://github.com/patrikx3/corifeus-web-material/blob/master/tsconfig.aot.json Is something changed? |
filipesilva
added
needs: investigation
|
Still same error on 1.9.0 |
|
I have given the repro steps, now it is Angular 5.1.1 and 1.9 and it is the same error. With a simple test it works, but given I have a complex repo I have no idea what the error is. Right now it doesn't even show what the error is in my repo, it is all about Very fishy. Is there something changed, I need a new decorator or what? I can't find the error. I guess you could understand more about the If I build it with |
|
I think it is not in sync with Angular itself. Some small error must be. Given with 1.8.0 it works, but I logged and the |
|
Isn't it because of this? In the |
|
i have uncommented but still error. I dont know. :( Reverted to 1.8.0. |
|
With 1.9.3 the error presists: |
|
How can I find out the error? Why it is somewhere an error in |
VersionsUsing webpack, not using Repro stepsIt is written here to repro: #8525 Observed behaviorIt is related to this: #8525 Desired behaviorShould not remove decorators or kindly fix it, so it works with my repro steps. Mention any other details that might be useful (optional)This file is in If I comment this code: // Remove unneeded angular decorators.
//this._transformers.push(removeDecorators(isAppPath, getTypeChecker));It works. Is there an options to keep the decorators? While is it removing something that is doing this? |
p3x-robot
changed the title
|
Ciao! |
|
Ciao! |
|
Ciao! |
|
Ciao! |
|
Seeing the same thing here. |
|
ciao! |
|
@getsaf no change at all, same error |
filipesilva
added
area: @ngtools/webpack
and removed
needs: investigation
|
@p3x-robot I mean template type-safety checks aren't run so any template errors aren't caught during the build. I do see the decorators and inlined html/scss in the output when I turn the flag off. I'm working in a rather large project with multiple teams so type checking the templates is necessary. I need a fix for this soon. |
|
For now, I created a hack: |
|
It works, with all latest versions, including Typescript 2.7.x |
|
Hi. I saw you have the same issue with AOT compiling and you also use Grunt with grunt-webpack. You might be interested to the issues I created: And most importantly here: webpack-contrib/grunt-webpack#168 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Versions
Not using
ng, just using@ngtools/webpackwithwebpack.Repro steps
tsconfig.aot.json{ "compilerOptions": { "skipLibCheck": true, "outDir": "build/aot", "target": "es5", "module": "commonjs", "moduleResolution": "node", "sourceMap": false, "emitDecoratorMetadata": true, "experimentalDecorators": true, "noImplicitAny": true, "suppressImplicitAnyIndexErrors": true, "lib": [ "es5", "es6", "dom", "es2015.collection", "es2015.promise", "es2015.core", "es2016", "es2017" ] }, "includes": [ "src/angular/**/*", "test/angular-webpack/**/*" ], "exclude": [ "node_modules", "src/angular/boot.ts", "test/angular-webpack/angular/boot.ts", "build/browser" ], "angularCompilerOptions": { "annotationsAs": "decorators", "preserveWhitespaces": false } }Observed behavior
Desired behavior
With
Angular 5.0.1it was working.Mention any other details that might be useful (optional)
Is
@ngtools/webpackbehind withAngular 5.0.2?The text was updated successfully, but these errors were encountered: