Skip to content

test: fix unit tests for 'my-lib' is not a known element #10405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2018
Merged

test: fix unit tests for 'my-lib' is not a known element #10405

merged 1 commit into from
Apr 23, 2018

Conversation

alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Apr 20, 2018

This fixes the tests that are currently failing on CI

@filipesilva
Copy link
Contributor

I haven't yet fixed this because I think it's a but on devkit. A library shouldn't get an automatic prefix IIRC.

/cc @Brocco

@alan-agius4
Copy link
Collaborator Author

alan-agius4 commented Apr 20, 2018 via email

@filipesilva filipesilva merged commit ee32918 into angular:master Apr 23, 2018
@filipesilva
Copy link
Contributor

Talked with the team, and libraries should use the lib prefix if none is provided after all. Thanks for fixing this @alan-agius4 !

@alan-agius4 alan-agius4 deleted the feature/unit-test branch April 24, 2018 04:16
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants