fix(@angular/cli): clean up architect options #10763
Conversation
filipesilva
force-pushed
the
clean-architect-options
branch
5 times, most recently
from
8a61f06 to
d37d29f
Compare
filipesilva
force-pushed
the
clean-architect-options
branch
from
d37d29f to
a1bc9f0
Compare
| project = options.project; | ||
| target = this.target; | ||
| configuration = options.configuration; | ||
| if (!configuration && options.prod) { |
There was a problem hiding this comment.
--prod is really only specific to a several commands. What about a utility function that handles the --prod helper option that can be called by the particular commands (build, server, e2e, test) before running this.runArchitectTarget(options);? Or even a sub-class for those commands since they are mostly identical otherwise?
There was a problem hiding this comment.
I started that way, but then it turned out that not having prod is specific to only one command ou of seven.
Having to massage the options in the six individual commands instead of doing it in ArchitectCommand seems like the better approach, especially since that sort of processing also needs to happen within ArchitectCommand for initialization and validation, which happens before running the command proper.
There was a problem hiding this comment.
It's awkward that it works on commands it should not but we can correct that moving forward.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fix #10699