Skip to content

Conversation

@JLHwung
Copy link
Contributor

@JLHwung JLHwung commented May 25, 2018

Copy link
Member

@clydin clydin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rename the message to feat instead of fix? Otherwise, it looks good.

@JLHwung JLHwung force-pushed the support-entry-components branch from f5bdb22 to 0920eac Compare May 30, 2018 01:30
@JLHwung JLHwung changed the title fix(@angular/cli): support entry component feat(@angular/cli): support entry component May 30, 2018
@JLHwung
Copy link
Contributor Author

JLHwung commented May 30, 2018

@clydin Reworded and thanks.

Edits: Test failure is unrelated, please retry the ci.

@clydin clydin merged commit 3ba18a9 into angular:master May 30, 2018
@JLHwung JLHwung deleted the support-entry-components branch May 30, 2018 14:36
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants