-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(@schematics/angular): update karma to v3.0 #11843
Conversation
This will need to be a |
@clydin updated the change. |
One more quick change: the scope for the commit message should be “@schematics/angular” |
@sibiraj-s please also mention "Close #10963" in the commit message so that the issue is automatically closed when the PR is merged. |
@sibiraj-s Additional (sorry for just piling on); could you also change the version in the root |
@hansl. Also karma-cli is redundant. Is it okay to remove that to? |
Then please do :) . We don't use the CLI, not sure why it's there. |
Done. This should also fix the timeout issues while testing in CI |
Looks good. Seems like your change might have some merging issue. Rebase and we'll merge it in as soon as caretaker is around (Monday at the latest). |
Hi @sibiraj-s! This PR has merge conflicts due to recent upstream merges. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Update Karma to v3.0.0 which resolves several vulnerable dependencies