Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@schematics/angular): update karma to v3.0 #11843

Merged
merged 2 commits into from
Aug 17, 2018
Merged

feat(@schematics/angular): update karma to v3.0 #11843

merged 2 commits into from
Aug 17, 2018

Conversation

sibiraj-s
Copy link
Contributor

Update Karma to v3.0.0 which resolves several vulnerable dependencies

@clydin
Copy link
Member

clydin commented Aug 10, 2018

This will need to be a feat since it changes the generated project.

@sibiraj-s
Copy link
Contributor Author

@clydin updated the change.

@clydin clydin added the target: major This PR is targeted for the next major release label Aug 10, 2018
@clydin clydin changed the title fix(@angular-devkit/schematics): update karma to v3.0 feat(@angular-devkit/schematics): update karma to v3.0 Aug 10, 2018
@clydin
Copy link
Member

clydin commented Aug 10, 2018

One more quick change: the scope for the commit message should be “@schematics/angular”

@sarunint
Copy link
Contributor

@sibiraj-s please also mention "Close #10963" in the commit message so that the issue is automatically closed when the PR is merged.

@sibiraj-s sibiraj-s changed the title feat(@angular-devkit/schematics): update karma to v3.0 feat(@schematics/angular): update karma to v3.0 Aug 10, 2018
@sibiraj-s
Copy link
Contributor Author

sibiraj-s commented Aug 10, 2018

@clydin . Updated the commit scope.

Since one of two issues in #10963 is already addressed. This Commit will close the issue

@hansl
Copy link
Contributor

hansl commented Aug 10, 2018

@sibiraj-s Additional (sorry for just piling on); could you also change the version in the root package.json? It will be installed for our tests.

@sibiraj-s
Copy link
Contributor Author

sibiraj-s commented Aug 10, 2018

@hansl. Also karma-cli is redundant. Is it okay to remove that to?

@hansl
Copy link
Contributor

hansl commented Aug 10, 2018

Then please do :) . We don't use the CLI, not sure why it's there.

@sibiraj-s
Copy link
Contributor Author

sibiraj-s commented Aug 10, 2018

Done.

This should also fix the timeout issues while testing in CI

hansl
hansl previously approved these changes Aug 11, 2018
@hansl
Copy link
Contributor

hansl commented Aug 11, 2018

Looks good. Seems like your change might have some merging issue. Rebase and we'll merge it in as soon as caretaker is around (Monday at the latest).

@ngbot
Copy link

ngbot bot commented Aug 17, 2018

Hi @sibiraj-s! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

@hansl hansl merged commit eb87002 into angular:master Aug 17, 2018
@sibiraj-s sibiraj-s deleted the patch-1 branch August 17, 2018 18:56
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants