-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(@angular-devkit/build-angular): use terser instead of uglify-es #11996
Conversation
Should help bring down prod build times, @SanderElias reported a ~60% reduction on his project. Should fix angular#9340.
@filipesilva Terser has no known issues with the Lines 232 to 234 in 8b7fa04
This code can probably be removed. |
@filipesilva Hi Filipe, may I ask when your team will release a new version which includes this PR? Thanks a lot :) |
@kubbafox this is now released in |
@filipesilva Is this an ng 7 only feature or can we expect to make use of it while remaining on ng 6.x? For. e. g. by just upgrading cli and/or the devkit packages? |
@kqadem right now it should work, but I can't guarantee that'll be the case as we go out of beta since the interface between |
@filipesilva Wow, thx for the quick reply! Alright, let's see how it comes. Having a quite big enterprise product here going to be launched soon prohitibing us major version changes. Since the change only involves switching a package, we might even consider kind of dirty mapping from uglify to terser... I mean, ~60% build time reduction 😱 |
Well that was for a specific project. I can't say that'll be the case for every project. Have you tried the beta on your app? |
I think I'm going to have a look at it by the end of the week.
yep, could be even more 😜 |
We had the same problem involving uglify-es. Changing the version of "angular-devkit/build-angular" to "0.9.0-rc.3", even with Angular CLI 6.2.5, our application is running again with older versions of FF without needing "build-optimizer=false". Thanks. |
@cquixada did you notice any improvements regarding build time? |
Now that angular#11996 landed, the CLi uses Terser instead of UglifyJS.
Now that angular#11996 landed, the CLI uses Terser instead of UglifyJS.
Now that angular#11996 landed, the CLI uses Terser instead of UglifyJS.
Now that #11996 landed, the CLI uses Terser instead of UglifyJS.
Now that angular#11996 landed, the CLI uses Terser instead of UglifyJS.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Should help bring down prod build times, @SanderElias reported a ~60% reduction on his project.
Should fix #9340.