Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "build: limit rxjs to 6.2.x due to a defect in 6.3.0 (#12048)" #12060

Closed
wants to merge 1 commit into from
Closed

Revert "build: limit rxjs to 6.2.x due to a defect in 6.3.0 (#12048)" #12060

wants to merge 1 commit into from

Conversation

alan-agius4
Copy link
Collaborator

This reverts commit 7e63dd7.

Verifying that rxjs 6.1.3 doesn't throw an error

@alan-agius4
Copy link
Collaborator Author

Blocked by: ReactiveX/rxjs#4078

@whyvrafvr
Copy link

Hi. I've just updated rxjs from 6.2.2 to 6.3.1 and got the error TypeError: sink._addParentTeardownLogic is not a function running a ng serve.

Is this linked with this ticket?

Copy link
Contributor

@hansl hansl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alan-agius4 I don't think we want to revert this change. Let's talk at the meeting but it's not the first time RxJS breaks us with a minor update. Maybe we could limit versions when publishing but not developing (to avoid people having problems when installing CLI)?

@clydin
Copy link
Member

clydin commented Sep 4, 2018

We should also set the minimum version to at least 6.2 as well. This brings in the exception handling fix that forced workaround code throughout the codebase.

@alan-agius4 alan-agius4 closed this Sep 4, 2018
@alan-agius4 alan-agius4 reopened this Sep 4, 2018
@alan-agius4 alan-agius4 closed this Sep 4, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants