Skip to content

fix json schema for angular.json to allow 'targets' property #12225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

zhuravlikjb
Copy link

Currently a newly created angular-cli project contains angular.json not passing checks with the json schema bundled with corresponding package:
image

The issue was reported by WebStorm QA as https://youtrack.jetbrains.com/issue/WEB-34738.

This PR fixes the issue, allowing 'targets' property.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@zhuravlikjb
Copy link
Author

signed the CLA

@googlebot
Copy link

CLAs look good, thanks!

@alan-agius4
Copy link
Collaborator

alan-agius4 commented Sep 10, 2018

Thank for your contribution but there is already a PR for this #12204

@crashsol
Copy link

signed the CLA

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants