docs: add jsdoc instead of comments #12269
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes was originally required for the API guardian as it was not liking the comments as they were. But I am going to land it separately.
jsdocs
/tsdocs
instead of comments.d.ts
to.ts
. This is due thatd.ts
don't get typechecked because we haveskipLibCheck
enabled which might result in invalid declarations. Referenceddts
files don’t get emitted by tsc, which means there should be a separate build process to copy this dts file to dist. And finally I'd very much like to avoid issues like this Cannot find name 'FileReplacements'. #11294 just because we use d.ts instead of .ts