Skip to content

feat(@ngtools/webpack): add support for traceResolution #12286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 17, 2018
Merged

feat(@ngtools/webpack): add support for traceResolution #12286

merged 1 commit into from
Sep 17, 2018

Conversation

@alan-agius4
Copy link
Collaborator

Closes #8676

@alan-agius4 alan-agius4 changed the title fix(ngtools/webpack): enabling traceResolution now prints module resolutions fix(@ngtools/webpack): enabling traceResolution now prints module resolutions Sep 17, 2018
@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Sep 17, 2018
filipesilva
filipesilva suggested changes Sep 17, 2018
View reviewed changes
packages/ngtools/webpack/src/compiler_host.ts
}

trace(message: string) {
console.log(message);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should use console.log for this, but not sure what else we should use. The webpack compilation only allows for warnings and errors, and they show only at the end of the compilation.

@clydin WDYT?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a side note, I don't think you'd want to display the traceResolutions all at the very end, as this is quite verbose. I think it is quite useful to see that output when a module is being resolved.

filipesilva
filipesilva suggested changes Sep 17, 2018
View reviewed changes
Copy link
Contributor

@filipesilva filipesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the original issue I thought this was a bug, but seeing the changes needed I think it's a feature since it changes the output and adds support for something that was not there before.

Can you change the scope please?

@alan-agius4
Copy link
Collaborator Author

@filipesilva updated scope as requested. Re the console.log I am not sure what else we can do instead.

@alan-agius4 alan-agius4 added target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels Sep 17, 2018
@alan-agius4 alan-agius4 changed the title fix(@ngtools/webpack): enabling traceResolution now prints module resolutions feat(@ngtools/webpack): add support for traceResolution Sep 17, 2018
@hansl hansl merged commit b65860f into angular:master Sep 17, 2018
@alan-agius4 alan-agius4 deleted the fix_trace branch September 18, 2018 04:15
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@filipesilva filipesilva filipesilva approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

target: major This PR is targeted for the next major release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

how to turn on module resolution stats provided by typescript compiler for an angular cli app?

5 participants

@alan-agius4 @filipesilva @alexeagle @hansl @googlebot