Skip to content

fix(@angular-devkit/build-angular): addresses issue were deployUrl #12360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 27, 2018
Merged

fix(@angular-devkit/build-angular): addresses issue were deployUrl #12360

merged 2 commits into from
Sep 27, 2018

Conversation

alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Sep 25, 2018

Closes #11952

@alan-agius4 alan-agius4 added target: patch This PR is targeted for the next patch release target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels Sep 25, 2018
filipesilva
filipesilva previously approved these changes Sep 26, 2018
@ngbot
Copy link

ngbot bot commented Sep 26, 2018

Hi @alan-agius4! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

filipesilva
filipesilva previously approved these changes Sep 26, 2018
This is due that when targeting an html file, when it doesn't exists it redirects to the root page. So instead use a `js` files to test
@hansl hansl merged commit d582d80 into angular:master Sep 27, 2018
@alan-agius4 alan-agius4 deleted the fix_deploy_url_serve branch September 27, 2018 19:49
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deploy-url does not change path of scripts with ng serve
4 participants