Deprecate defaultProject

[filipesilva]

More context in #11111 (comment)

Fix #11111

[alan-agius4]

Same

[filipesilva]

Ah yes, that's better, thanks!

[alexeagle]

this looks wrong, shouldn't it be on the following option?

[filipesilva]

Jeez, that's what I get for amending commits in a rush. Didn't even notice. Fixed now.

[alan-agius4]

Nit: you have an extra * at the end

[filipesilva]

Thanks, fixed

[alexeagle]

Blocked because we will reopen a larger discussion of project layout for ng8

[ngbot]

Hi @filipesilva! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

[filipesilva]

We need to actually design what non-project scoped commands should do. Currently default project almost never applies, and when it does it might not be the right thing anyway.

[SchnWalter]

From what I can tell from #11111 (comment), this PR should be closed. Although there are still inconsistencies between various commands where the project name is sometimes passed using --projects and other times it's --name. I'll look into this in the upcoming weeks and if it's clear what the default flag should be, I'll create some PRs to streamline the options.

L.E. In this repository, the "simple" (component, module, etc) schematics are consistent, the inconsistency is in the more complex schematics, see:

File Path	Property Name	Default value
packages/_/devkit/package/schema.json	name	argv #0
packages/angular/pwa/pwa/schema.json	name	projectName
packages/schematics/angular/app-shell/schema.json	clientProject	projectName
packages/schematics/angular/application/schema.json	name	argv #0 + x-prompt
packages/schematics/angular/e2e/schema.json	relatedAppName	undefined
packages/schematics/angular/library/schema.json	name	argv #0 + x-prompt
packages/schematics/angular/ng-new/schema.json	name	argv #0 + x-prompt
packages/schematics/angular/universal/schema.json	clientProject	undefined
----------	---------------	--------------
packages/schematics/angular/class/schema.json	project	projectName
packages/schematics/angular/directive/schema.json	project	projectName
packages/schematics/angular/enum/schema.json	project * Longer description, not really needed.	projectName
packages/schematics/angular/guard/schema.json	project	projectName
packages/schematics/angular/interceptor/schema.json	project	projectName
packages/schematics/angular/interface/schema.json	project	projectName
packages/schematics/angular/module/schema.json	project	projectName
packages/schematics/angular/pipe/schema.json	project	projectName
packages/schematics/angular/service/schema.json	project	projectName
packages/schematics/angular/service-worker/schema.json	project	projectName
packages/schematics/angular/web-worker/schema.json	project	projectName

And there are also a few inconsistencies in the https://github.com/angular/angular repository:

File Path	Property Name	Default value
packages/bazel/src/schematics/ng-add/schema.json	name	argv #0
packages/bazel/src/schematics/ng-new/schema.json	name	argv #0
packages/elements/schematics/ng-add/schema.json	project	projectName
packages/localize/schematics/ng-add/schema.json	name	projectName
aio/content/examples/schematics-for-libraries/projects/my-lib/schematics/my-service/schema.json	project	projectName

The https://github.com/angular/components repository has consistent names in the schematics:

File Path	Property Name	Default value
src/cdk/schematics/ng-add/schema.json	project	projectName
src/cdk/schematics/ng-generate/drag-drop/schema.json	project	projectName
src/material/schematics/ng-add/schema.json	project	projectName
src/material/schematics/ng-generate/address-form/schema.json	project	projectName
src/material/schematics/ng-generate/dashboard/schema.json	project	projectName
src/material/schematics/ng-generate/navigation/schema.json	project	projectName
src/material/schematics/ng-generate/table/schema.json	project	projectName
src/material/schematics/ng-generate/tree/schema.json	project	projectName

[dgp1130]

Going through old PRs. After some discussion, we still think we should deprecate defaultProject, but this PR is fairly old and not usable in its current state anyways. Filed #20661 to follow up with a deprecation.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}