Skip to content

fix(@angular-devkit/build-angular): don't rerun tests on unchanged co… #12402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 1, 2018
Merged

fix(@angular-devkit/build-angular): don't rerun tests on unchanged co… #12402

merged 1 commit into from
Oct 1, 2018

Conversation

filipesilva
Copy link
Contributor

…mpilation

Fix #11880

@filipesilva filipesilva mentioned this pull request Sep 28, 2018
Closed
@filipesilva filipesilva requested a review from clydin September 28, 2018 16:20
@filipesilva filipesilva added the target: major This PR is targeted for the next major release label Sep 28, 2018
clydin
clydin reviewed Sep 28, 2018
View reviewed changes
packages/angular_devkit/build_angular/test/karma/rebuilds_spec_large.ts
it('does not rebuild when nothing changed', (done) => {
// Start the server in watch mode, wait for the first build to finish, touch
// test.js without changing it, wait 5s then exit unsuscribe, verify only one event was emitted.
}, 30000);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no code in here. is that intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeap, see the comment above. We can't actually test karma in watch mode because there's no way for the karma server to exit gracefully without killing the processes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This at least needs a comment, anyone looking at this code later will be very confused why it claims to test something and then doesn't.
Did you think about another way to test this?

@alexeagle alexeagle merged commit 61ce0ce into angular:master Oct 1, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexeagle alexeagle alexeagle left review comments

@clydin clydin clydin approved these changes

Assignees
No one assigned
Labels
target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tests Run When Swap Files (*.swp, *.swo, *.swn, ...) Change
4 participants
@filipesilva @alexeagle @clydin @googlebot