-
Notifications
You must be signed in to change notification settings - Fork 12k
fix(@ngtools/webpack): emit lazy routes errors on rebuilds #12418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can you measure rebuild performance with this change? The original reason for the AST method was performance concerns. |
@clydin looks to be in the same range on a same app. Now:
Before
|
|
Blocking this for 7.0 to limit risk in the RC period. |
@alan-agius4 does this PR also fix #12311? |
Hi @alan-agius4! This PR has merge conflicts due to recent upstream merges. |
@alan-agius4 this is ready to merge but has a merge conflict, could you rebase please? |
At the moment lazy route errors are only emitted in the initial builds because in following builds we are only processed lazy routes that are declared in the changed files. At the moment, we cannot cache the previously resolved routes as there is no way to track in which file the lazy route was declared so that we can bust the lazy route if it was removed. Closes #12236
@alexeagle rebase done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool then, I updated the PR description to also close the other issue.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
At the moment lazy route errors are only emitted in the initial builds because in following builds we are only processed lazy routes that are declared in the changed files.
At the moment, we cannot cache the previously resolved routes as there is no way to track in which file the lazy route was declared so that we can bust the lazy route if it was removed.
Closes #12236
Closes #12311