fix(@angular-devkit/build-angular): remove skipAppShell as it has no effect in browser builder
#12790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
the
target: major
alan-agius4
changed the title
skipAppShell as it has no effect on browser builderskipAppShell as it has no effect in browser builder
…o effect in browser builder Closes #11478
filipesilva
approved these changes
Oct 29, 2018
filipesilva
added
state: blocked
needs: discussion
|
Yeah I'm not completely sure here either. I think we should error but maybe we have migrated the flag in the past? In any case it does nothing right now. |
|
We should have some helpful output in case the user uses this option |
alexeagle
removed
the
needs: discussion
|
Superseeded by #12965 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was not sure, if to deprecate and show a warning when using this options. But based on Filipe's comment. It should error out.
Closes #11478