-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(angularMajorCompatGuarantee): add check for range === null fixes #12644 #12806
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I've signed it |
CLAs look good, thanks! |
e3c780c
to
f7b164b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kindly also fix the commit message as per guidelines https://github.com/angular/angular-cli/blob/master/CONTRIBUTING.md
fix(@schematics/update): add check for invalid ranges
Fixes #12644
5782db3
to
3ecef49
Compare
Can you please rebase? |
rebased |
@alan-agius4 any idea why some of the checks are failing? |
That is because this method return type should not be of type boolean but rather string. |
@tkrugg the build is still failing. Would you fix the typing errors? |
@tkrugg can you check the above comment? Thank you. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes #12644