-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(@schematics/angular): addProviderToModule bug: add providers into inner Object #13081
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
150a771
to
8bd8769
Compare
CLAs look good, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this.
Kindly squash your commits into a single one, and also can you kindly add a Unit Test for this?
8e888a4
to
d40a4c0
Compare
…ot inner Object with ut.
@alan-agius4 Thanks for checking! I adopted your suggestions and updated this pr. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
@bsdfzzzy can you please fix the commit msg as you have a typo? Thanks |
@alan-agius4 emmm...Which one please... |
|
@alan-agius4 emmm... I mean Unit Test. |
@alan-agius4 By the way, could you tell me when can this issue be solved if you know? |
…ot inner Object with ut. (#13081)
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fix bug when add providers into module.
Fixes: #13080