fix(@schematics/angular): generate workspace tslint and .editorconfig… #13354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in minimal workspaces and applications When in minimal, tslint does get installed thus the tslint config should also be created, as this will break The minimal flags definition stats that the project will be created without any testing frameworks. Fixes #13054
alan-agius4
commented
Jan 3, 2019
| "protractor": "~5.4.0",<% } %> | ||
| "ts-node": "~7.0.0", | ||
| "protractor": "~5.4.0", | ||
| "ts-node": "~7.0.0",<% } %> |
There was a problem hiding this comment.
Note: ts-node is used with protoactor
When generating a minimal project test builder config is not required.
clydin
added
the
needs: discussion
|
Actually, we might want to go in the other direction and not install tslint. I'll mark this for discussion as a more formal definition of minimal is needed. |
|
See also: #9160 (comment) |
|
Superseded by #13408 |
hansl
removed
needs: discussion
This was referenced Jun 11, 2019
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… in minimal workspaces and applications
When in minimal, tslint does get installed thus the tslint config should also be created, as this will break
The minimal flags definition stats that the project will be created without any testing frameworks.
Fixes #13054