Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@schematics/angular): stop offering SASS option for ng new #13444

Merged
merged 1 commit into from
Jan 15, 2019

Conversation

alexeagle
Copy link
Contributor

The old Sass language referred to as "SASS" here is no longer relevant. This was denoted with the file extension ".sass"
Any new projects should use the modern Sass language which is expressed in ".scss" files.
This change does not remove any support for projects which were already created with ".sass" files, we simply stop offering
this option when creating new projects.

Also correct the capitalization of Less based on how they spell it on their website.

The old Sass language referred to as "SASS" here is no longer relevant. This was denoted with the file extension ".sass"
Any new projects should use the modern Sass language which is expressed in ".scss" files.
This change does not remove any support for projects which were already created with ".sass" files, we simply stop offering
this option when creating new projects.

Also correct the capitalization of Less based on how they spell it on their website.
@alexeagle alexeagle requested a review from hansl January 15, 2019 22:15
@alexeagle alexeagle added the target: major This PR is targeted for the next major release label Jan 15, 2019
@andy23512
Copy link

Hi all,
With reading some related issues, I still don't understand the reason for dropping support to .sass files. This causes some trouble to ones who want to use the old indented-syntax (at least in newly generated projects). Is it dropped just because it is an old syntax? Could someone explain the reason for me, please?

@ericcoulthard
Copy link

I would also like to know the reason for dropping support to .sass files. Weren't .sass and .scss released at the same time? So it doesn't make sense to me to call .sass the old language.

@ben-wall
Copy link

I thought there was a bug (ng g c component-name --style=sass no longer works, either, it's producing scss files )
I can't believe they merged this...
What about those of us who prefer using the sass indented syntax?
This is really a problem for my workflow as I am using
let g:angular_cli_stylesheet_format = 'sass'
in my .vimrc file.
This really needs to be reverted.

@0x7FFFFFFFFFFFFFFF
Copy link

I'm about to submit a bug and I found this. Could someone explain the reason why sass support was removed? You can remove a feature in Angular but please at least describe a little bit about the reason.

@ben-wall
Copy link

I'm about to submit a bug and I found this. Could someone explain the reason why sass support was removed? You can remove a feature in Angular but please at least describe a little bit about the reason.

This is already added back in about 10 days ago; see the reference to the previous comment.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants