feat(@angular-devkit/build-optimizer): also fold ES2015 classes #13496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipesilva
added
the
target: major
alan-agius4
reviewed
Jan 22, 2019
packages/angular_devkit/build_optimizer/src/transforms/class-fold.ts
Outdated
Show resolved
Hide resolved
clydin
reviewed
Jan 22, 2019
packages/angular_devkit/build_optimizer/src/transforms/class-fold.ts
Outdated
Show resolved
Hide resolved
clydin
reviewed
Jan 22, 2019
packages/angular_devkit/build_optimizer/src/transforms/class-fold.ts
Outdated
Show resolved
Hide resolved
filipesilva
force-pushed
the
es2015-classes
branch
from
fd73378 to
02239a5
Compare
Although ES5 classes had their static properties folded in, ES2015 ones did not. This PR adds that new functionality. It should also make this particular transform a bit faster since it will stop early. Fix angular#13487
filipesilva
force-pushed
the
es2015-classes
branch
from
02239a5 to
204596f
Compare
clydin
approved these changes
Jan 22, 2019
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although ES5 classes had their static properties folded in, ES2015 ones did not.
This PR adds that new functionality.
It should also make this particular transform a bit faster since it will stop early.
Fix #13487