Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular/cli): Add an error message when we call ng doc without… #13604

Merged
merged 1 commit into from
Feb 7, 2019

Conversation

wKoza
Copy link
Contributor

@wKoza wKoza commented Feb 6, 2019

… keyword. Currently, we open a page with the keyword undefined.

Copy link
Member

@mgechev mgechev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! There's another issue with doc it doesn't work on windows #13575

@mgechev
Copy link
Member

mgechev commented Feb 6, 2019

Validate seem unhappy because of the commit message

@wKoza
Copy link
Contributor Author

wKoza commented Feb 6, 2019

Yes, I've seen but I'm not well equipped Windows 😉...

… keyword. Currently, we open a page with the keyword `undefined`.
@wKoza
Copy link
Contributor Author

wKoza commented Feb 6, 2019

validate doesn't like --fixup ? OK OK ...

@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Feb 7, 2019
This was referenced Feb 12, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants