fix(@schematics/angular): default newProjectRoot to current directory

[clydin]

Fixes #13704

[FrozenPandaz]

@clydin FYI, this does not fix the breaking change which we discussed. There is still logic which expects newProjectRoot to be (or not to be) undefined.

[clydin]

newProjectRoot is only in a conditional which checks if it is truthy in the application schematic:

angular-cli/packages/schematics/angular/application/index.ts

Line 351 in dad48c3

projectRoot: newProjectRoot ? `${newProjectRoot}/${options.name}-e2e` : 'e2e',

I updated the PR to maintain the existing behavior for that case. Even though there is an argument to be made that it is actually a defect. As is, the 'e2e' directory would overlap an existing 'e2e' folder at the workspace root and the schematic would fail in the case of the workspace's newProjectRoot being falsy.

[FrozenPandaz]

Awesome! Those changes fix the breaking change.

Thank you so much!

[hansl]

Isn't that a breaking change? This seems to be 2 changes; a fix and a feature...

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}