Skip to content

fix(test) corrected order of loaded files #1379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

choeller
Copy link

According to angular/angular#9815 system-polyfills.js needs to be loaded before zone.js

According to angular/angular#9815 system-polyfills.js needs to be loaded before zone.js
@aciccarello
Copy link
Contributor

Will system-polyfills.js be needed if SystemJs is being removed? (see #1376)

@choeller
Copy link
Author

Good question ;) Didn't know SystemJS would be completely dropped, so I thought under the hood SystemJS would still do the loading, if that's not the case maybe it can be deleted here. on the other hand #1376 also didn't drop it from karma.conf.js. maybe @filipesilva can shed some light ;)

@filipesilva
Copy link
Contributor

If we go down the webpack route, SystemJS is not needed because webpack is not using it (it's using it's own System implementation).

#1376 didn't remove it from karma.conf.js no, but only because it's already removed in the webpack branch (that PR is to merge code into that branch).

I'm going to leave this PR open for now though, because until the webpack branch is merged, it's not final.

@filipesilva
Copy link
Contributor

Closed as this PR was made obsolete by #1455.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants