-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(@schematics/angular): tslint migration for 8 #13801
Conversation
df4d561
to
8ce7c3c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above comments
LGTM, @mgechev :) |
@@ -33,6 +33,9 @@ const ruleMapping: {[key: string]: string} = { | |||
'no-template-call-expression': 'template-no-call-expression', | |||
'templates-no-negated-async': 'template-no-negated-async', | |||
'trackBy-function': 'template-use-track-by-function', | |||
'no-attribute-parameter-decorator': 'no-attribute-decorator', | |||
'component-change-detection': 'prefer-on-push-component-change-detection', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This rule is not released yet so I think you can get rid of this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing is released yet. I'd add a label "blocked" so we don't merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean that the rule component-change-detection
doesn't need to be updated because it'll probably only be released on the next major of Codelyzer.
93e90a3
to
4bdd3e4
Compare
327e71a
to
544927e
Compare
544927e
to
367d3a7
Compare
1ff591f
to
243c2f1
Compare
Migration of the `tslint.json` and `package.json` files required by the refactoring of codelyzer. For more information check this PR mgechev/codelyzer#754.
243c2f1
to
4e50a6e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
'templates-no-negated-async': 'template-no-negated-async', | ||
'trackBy-function': 'template-use-track-by-function', | ||
'no-attribute-parameter-decorator': 'no-attribute-decorator', | ||
'max-inline-declarations': 'component-max-inline-declarations', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rule 'component-change-detection': 'prefer-on-push-component-change-detection'
should be added now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wKoza this rule did not exist before. It's part of v5 beta, already with the "new" name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I didn't understand your previous comment and I see this rule since a lot of time.
const dependency: NodeDependency = { | ||
type: NodeDependencyType.Dev, | ||
name: 'codelyzer', | ||
version: '^5.0.0', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, we use the tilde ~
. this change is it wanted ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've been careful with not introducing breaking changes between minor releases. I think we can have a ^
.
@@ -0,0 +1,103 @@ | |||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this the index
file? aren't there a bunch of migrations for 8? I'd expect this to be update-codelyzer or something
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a follow up PR for polyfills migration. I'll update the script there.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Migration of the
tslint.json
file required by the refactoring ofcodelyzer. For more information check this PR
mgechev/codelyzer#754.
// cc @rafaelss95, would you check if I've missed anything?