Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@schematics/angular): tslint migration for 8 #13801

Merged
merged 1 commit into from
Mar 27, 2019

Conversation

mgechev
Copy link
Member

@mgechev mgechev commented Mar 1, 2019

Migration of the tslint.json file required by the refactoring of
codelyzer. For more information check this PR
mgechev/codelyzer#754.

// cc @rafaelss95, would you check if I've missed anything?

@mgechev mgechev marked this pull request as ready for review March 1, 2019 22:33
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above comments

@rafaelss95
Copy link

LGTM, @mgechev :)

@@ -33,6 +33,9 @@ const ruleMapping: {[key: string]: string} = {
'no-template-call-expression': 'template-no-call-expression',
'templates-no-negated-async': 'template-no-negated-async',
'trackBy-function': 'template-use-track-by-function',
'no-attribute-parameter-decorator': 'no-attribute-decorator',
'component-change-detection': 'prefer-on-push-component-change-detection',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This rule is not released yet so I think you can get rid of this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing is released yet. I'd add a label "blocked" so we don't merge.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean that the rule component-change-detection doesn't need to be updated because it'll probably only be released on the next major of Codelyzer.

@mgechev mgechev force-pushed the minko/migrate-codelyzer branch 2 times, most recently from 93e90a3 to 4bdd3e4 Compare March 4, 2019 19:57
@mgechev mgechev force-pushed the minko/migrate-codelyzer branch 2 times, most recently from 327e71a to 544927e Compare March 7, 2019 05:21
scripts/test.ts Outdated Show resolved Hide resolved
@mgechev mgechev force-pushed the minko/migrate-codelyzer branch 2 times, most recently from 1ff591f to 243c2f1 Compare March 12, 2019 19:39
Migration of the `tslint.json` and `package.json` files required by the refactoring of
codelyzer. For more information check this PR
mgechev/codelyzer#754.
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

'templates-no-negated-async': 'template-no-negated-async',
'trackBy-function': 'template-use-track-by-function',
'no-attribute-parameter-decorator': 'no-attribute-decorator',
'max-inline-declarations': 'component-max-inline-declarations',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rule 'component-change-detection': 'prefer-on-push-component-change-detection' should be added now.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wKoza this rule did not exist before. It's part of v5 beta, already with the "new" name.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I didn't understand your previous comment and I see this rule since a lot of time.

const dependency: NodeDependency = {
type: NodeDependencyType.Dev,
name: 'codelyzer',
version: '^5.0.0',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, we use the tilde ~. this change is it wanted ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've been careful with not introducing breaking changes between minor releases. I think we can have a ^.

@@ -0,0 +1,103 @@
/**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this the index file? aren't there a bunch of migrations for 8? I'd expect this to be update-codelyzer or something

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a follow up PR for polyfills migration. I'll update the script there.

@mgechev mgechev added target: major This PR is targeted for the next major release and removed state: blocked labels Mar 27, 2019
@kyliau kyliau merged commit 4b89fe2 into angular:master Mar 27, 2019
mgechev referenced this pull request in mgechev/codelyzer Apr 29, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants