Skip to content

Update build system to use core-js 3 #13981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 4, 2019
Merged

Conversation

clydin
Copy link
Member

@clydin clydin commented Mar 25, 2019

Also, required ES polyfills are now managed directly by the build system. If additional polyfills are required, packages can be manually added as needed. This reduces the number of direct dependencies for a new project.

@clydin clydin added the target: major This PR is targeted for the next major release label Mar 25, 2019
@clydin clydin force-pushed the polyfills-es2015 branch from 9d04883 to 11e1e26 Compare March 25, 2019 18:04
@alan-agius4
Copy link
Collaborator

@clydin, can you kindly reference #13954?

@clydin clydin force-pushed the polyfills-es2015 branch from 11e1e26 to 8ec97f4 Compare March 25, 2019 18:42
@clydin clydin force-pushed the polyfills-es2015 branch from 8ec97f4 to 50a78e9 Compare March 25, 2019 22:46
@clydin clydin requested a review from alan-agius4 March 25, 2019 23:04
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clydin clydin force-pushed the polyfills-es2015 branch 2 times, most recently from 97c0535 to 529f824 Compare March 27, 2019 00:55
eranshmil added a commit to botim/dashboard that referenced this pull request Mar 27, 2019
waiting for PR angular/angular-cli#13981 to be merged and released
import 'core-js/es/promise';

// ES2015 object capabilities
import 'core-js/es/object/create';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it necessary to import each function individually?
Why not import everything at once by import 'core-js/es/object';?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Angular only requires the ES2015 polyfills. In core-js 3.0, core-js/es/object includes all current ES polyfills (up to ES2019). This was an attempt to reduce the bundle size increase. Using the single imports resulted in an increase of ~15kb to the polyfills file. Further work is currently being done to attempt to close the gap even further.

@clydin clydin force-pushed the polyfills-es2015 branch from 529f824 to d1a1808 Compare April 3, 2019 01:35
clydin added 2 commits April 3, 2019 09:53
…rojects

Required polyfills are now managed directly by the build system.  If additional polyfills are required, packages can be manually added as needed.
@clydin clydin force-pushed the polyfills-es2015 branch from d1a1808 to ffb48ad Compare April 3, 2019 13:53
@clydin clydin removed the state: WIP label Apr 3, 2019
@alexeagle alexeagle merged commit a0a583a into angular:master Apr 4, 2019
@clydin clydin deleted the polyfills-es2015 branch April 4, 2019 16:30
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants