feat(env): decouple build from env file #1404

filipesilva · 2016-07-21T04:31:03Z

hansl · 2016-07-21T04:31:46Z

addon/ng2/commands/build.ts

@@ -16,28 +17,40 @@ module.exports = Command.extend({
  aliases: ['b'],

  availableOptions: [
-    { name: 'environment',    type: String,  default: 'development', aliases: ['e', { 'dev': 'development' }, { 'prod': 'production' }] },
+    { name: 'target',    type: String,  default: 'development', aliases: ['t', { 'dev': 'development' }, { 'prod': 'production' }] },


alignment on type:

hansl · 2016-07-21T04:40:06Z

README.md

-At build time, the `src/app/environment.ts` will be replaced by either
-`config/environment.dev.ts` or `config/environment.prod.ts`, depending on the
-current cli environment. The resulting file will be `dist/app/environment.ts`.
+A build can specify both a build target (`development` or `production`) and a 


"and a**n**"

hansl · 2016-07-21T17:21:51Z

Could you add an e2e for if I specify a target that doesn't exist (should error), and if I specify an environment that doesn't exist (should also error)?

Code looks good to me otherwise. Cheers!

filipesilva · 2016-07-22T00:17:02Z

@hansl added the tests.

hansl · 2016-07-22T00:18:23Z

LGTM

* build: use webpack for building apps. This pull request replaces the underlying broccoli build system and then replaces it with webpack as the build and bundler. This will affect the following commands (however the user-level) functionality should go unchanged (besides unimplemented flags which will come after this PR.): ng build (with --env flag and --watch flag supported) ng serve (with --port flag supported) ng test / ng e2e The webpack configuration is blackboxed, and therefore users will not see a webpack.config.js file in their repository. Also this PR will bump the typescript version to 2.0 (beta). Fixes #909 #1155 #882 * chore(lint) Corrected any eslint errors and cleaned up unused files * chore(cleanup) additional cleanup tasks performed. Removed unneeded code, indentation causing linting errors, add back tsconfig sourcemapping, removed console logs, deleted material unused files. * chore: remove bind from serve command * chore: simplify test command * chore: fix test warnings * chore: revert whitespace changes * chore: re-add mapRoot to tsconfig * chore: remove unused import * bugfix: fix broken tests * fix: fix mobile-specific feature test * bugfix: fix public folder test * fix: fixes for path mappings, tests, and coverage (#1359) * fix(): Multiple fixes for path mappings: * Removed invalid test case that was throwing path mappings tests because of a typescript bug. * Readded PathsPlugin for Path Mappings * Removed coverage preprocessor which was throwing bad type errors against ts code when it shouldn't be. * Added sourcemap support for istanbul instrumenter. Coverage files are still being generated. * fix: fix the way the build command runs for mobile tests * fix: fix the way the build command runs for mobile tests * fix: replaced promise based ng command with sh.exec to allow mappings test to run correctly against mobile * fix: replaced promise based ng command with sh.exec to allow mappings test to run correctly against mobile * fix: add environment configuration replacement (#1364) * fix: add environment configuration replacement * remove debuggers * fix: move mobile test above config test because it relies on prod build from previous step * fix: removed unneeded interface moved config paths * fix(tests): re-enable sass/less/stylus tests (#1363) * chore: remove systemjs (#1376) * chore: remove vendor.ts (#1383) * chore: remove material2 test option (#1385) * fix(build): re-add support for sourceDir (#1378) * chore(build): remove broccoli (#1386) * chore: remove windows elevation check (#1384) * fix(test): add missing sourceDir (#1387) * fix: update node polyfill support properties for prod config to allow dev-server (aka ng serve) (#1395) * chore(tests): add prod env e2e test (#1394) * chore: cleanup of new files (#1388) * fix(serve): disable HMR (#1402) * chore: review docs (#1407) * feat(env): decouple build from env file (#1404) * fix: fix tsconfig for editors (#1420) * chore: fix webpack branch after merge conflicts (#1423) * fix: update to awesome-typescript-loader 2.1.0 (#1425) * fix: update to awesome-typescript-loader 2.1.0 which fixes a few issues shimming typings libs in tsconfig.json * fix: forgot to set libs in tsconfig blueprint * chore(blueprints): remove module.id (#1426) * feat: add host flag support for ng serve (#1442) * feat(test): add karma plugin (#1437) * chore(blueprints): re-add outDir (#1428) * feat: use @types instead of typings (#1449) * fix: make sourcemaps work in test (#1447) * feat: add utilities for typescript ast (#1159) (#1453) 'ast-utils.ts' provides typescript ast utility functions

* build: use webpack for building apps. This pull request replaces the underlying broccoli build system and then replaces it with webpack as the build and bundler. This will affect the following commands (however the user-level) functionality should go unchanged (besides unimplemented flags which will come after this PR.): ng build (with --env flag and --watch flag supported) ng serve (with --port flag supported) ng test / ng e2e The webpack configuration is blackboxed, and therefore users will not see a webpack.config.js file in their repository. Also this PR will bump the typescript version to 2.0 (beta). Fixes angular#909 angular#1155 angular#882 * chore(lint) Corrected any eslint errors and cleaned up unused files * chore(cleanup) additional cleanup tasks performed. Removed unneeded code, indentation causing linting errors, add back tsconfig sourcemapping, removed console logs, deleted material unused files. * chore: remove bind from serve command * chore: simplify test command * chore: fix test warnings * chore: revert whitespace changes * chore: re-add mapRoot to tsconfig * chore: remove unused import * bugfix: fix broken tests * fix: fix mobile-specific feature test * bugfix: fix public folder test * fix: fixes for path mappings, tests, and coverage (angular#1359) * fix(): Multiple fixes for path mappings: * Removed invalid test case that was throwing path mappings tests because of a typescript bug. * Readded PathsPlugin for Path Mappings * Removed coverage preprocessor which was throwing bad type errors against ts code when it shouldn't be. * Added sourcemap support for istanbul instrumenter. Coverage files are still being generated. * fix: fix the way the build command runs for mobile tests * fix: fix the way the build command runs for mobile tests * fix: replaced promise based ng command with sh.exec to allow mappings test to run correctly against mobile * fix: replaced promise based ng command with sh.exec to allow mappings test to run correctly against mobile * fix: add environment configuration replacement (angular#1364) * fix: add environment configuration replacement * remove debuggers * fix: move mobile test above config test because it relies on prod build from previous step * fix: removed unneeded interface moved config paths * fix(tests): re-enable sass/less/stylus tests (angular#1363) * chore: remove systemjs (angular#1376) * chore: remove vendor.ts (angular#1383) * chore: remove material2 test option (angular#1385) * fix(build): re-add support for sourceDir (angular#1378) * chore(build): remove broccoli (angular#1386) * chore: remove windows elevation check (angular#1384) * fix(test): add missing sourceDir (angular#1387) * fix: update node polyfill support properties for prod config to allow dev-server (aka ng serve) (angular#1395) * chore(tests): add prod env e2e test (angular#1394) * chore: cleanup of new files (angular#1388) * fix(serve): disable HMR (angular#1402) * chore: review docs (angular#1407) * feat(env): decouple build from env file (angular#1404) * fix: fix tsconfig for editors (angular#1420) * chore: fix webpack branch after merge conflicts (angular#1423) * fix: update to awesome-typescript-loader 2.1.0 (angular#1425) * fix: update to awesome-typescript-loader 2.1.0 which fixes a few issues shimming typings libs in tsconfig.json * fix: forgot to set libs in tsconfig blueprint * chore(blueprints): remove module.id (angular#1426) * feat: add host flag support for ng serve (angular#1442) * feat(test): add karma plugin (angular#1437) * chore(blueprints): re-add outDir (angular#1428) * feat: use @types instead of typings (angular#1449) * fix: make sourcemaps work in test (angular#1447) * feat: add utilities for typescript ast (angular#1159) (angular#1453) 'ast-utils.ts' provides typescript ast utility functions

angular-automatic-lock-bot · 2019-09-10T01:42:03Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

With this change we replace the aspnet-engine to use the common engine to fix a number of problems. 1) Injector has already been destroyed. Error: Injector has already been destroyed. 2) Mismatching HTML snapshots. This does come with a drawback, that we needed to remove `moduleRef` from the `IEngineRenderResult` this however shouldn't cause any problem since this couldn't be used because the platform would have already been destroyed. Fixes angular#1808 Fixes angular#1404

googlebot added the cla: yes label Jul 21, 2016

filipesilva mentioned this pull request Jul 21, 2016

Webpack build system upgrade tracker #1356

Closed

28 tasks

hansl reviewed Jul 21, 2016
View reviewed changes

filipesilva force-pushed the add-arbitrary-config branch from e95d36f to 3515137 Compare July 21, 2016 04:34

hansl reviewed Jul 21, 2016
View reviewed changes

filipesilva force-pushed the add-arbitrary-config branch from 3515137 to 3592033 Compare July 21, 2016 14:33

filipesilva force-pushed the add-arbitrary-config branch 9 times, most recently from c6e7b20 to b110d12 Compare July 21, 2016 23:41

feat(env): decouple build from env file

704d817

filipesilva force-pushed the add-arbitrary-config branch from b110d12 to 704d817 Compare July 21, 2016 23:55

hansl added the pr_state: LGTM label Jul 22, 2016

filipesilva merged commit 23e5eb9 into angular:webpack Jul 22, 2016

filipesilva deleted the add-arbitrary-config branch July 22, 2016 00:18

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(env): decouple build from env file #1404

feat(env): decouple build from env file #1404

filipesilva commented Jul 21, 2016

hansl Jul 21, 2016 •

edited

Loading

filipesilva Jul 21, 2016

hansl Jul 21, 2016

filipesilva Jul 21, 2016

hansl commented Jul 21, 2016

filipesilva commented Jul 22, 2016

hansl commented Jul 22, 2016

angular-automatic-lock-bot bot commented Sep 10, 2019

feat(env): decouple build from env file #1404

feat(env): decouple build from env file #1404

Conversation

filipesilva commented Jul 21, 2016

hansl Jul 21, 2016 • edited Loading

Choose a reason for hiding this comment

filipesilva Jul 21, 2016

Choose a reason for hiding this comment

hansl Jul 21, 2016

Choose a reason for hiding this comment

filipesilva Jul 21, 2016

Choose a reason for hiding this comment

hansl commented Jul 21, 2016

filipesilva commented Jul 22, 2016

hansl commented Jul 22, 2016

angular-automatic-lock-bot bot commented Sep 10, 2019

hansl Jul 21, 2016 •

edited

Loading