fix(@angular-devkit/build-angular): remove pure_getters #14187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clydin
approved these changes
Apr 16, 2019
filipesilva
added
target: major
Contributor
Author
|
Blocked on angular/angular#29929. |
filipesilva
force-pushed
the
remove-pure-getters
branch
from
0f4cf19 to
04322b3
Compare
When we first started using Build Optimizer, we saw a lot of the savings were tied to using the Uglify/Terser `pure_getters` option. This was intimately related with the structure and shape of the Angular codebase. The measurements we did at the time on angular.io showed a significant size reduction, from 1mb to about 600kb. Of these roughly 150kb were tied to using `pure_getters` if I remember correctly. Meanwhile the Angular codebase has changed significantly and I don't really see these savings anymore, so I don't think it makes sense to keep it on given that it is known to cause problems with some libraries. Closes angular#9231, angular#11439, angular#12096, angular#12128.
filipesilva
force-pushed
the
remove-pure-getters
branch
from
04322b3 to
e094fa2
Compare
filipesilva
force-pushed
the
remove-pure-getters
branch
from
e094fa2 to
4e55bf6
Compare
clydin
requested changes
Apr 24, 2019
packages/angular_devkit/build_angular/src/angular-cli-files/models/webpack-configs/common.ts
Outdated
Show resolved
Hide resolved
packages/angular_devkit/build_angular/src/angular-cli-files/models/webpack-configs/common.ts
Outdated
Show resolved
Hide resolved
filipesilva
force-pushed
the
remove-pure-getters
branch
from
4e55bf6 to
fe485c4
Compare
clydin
approved these changes
Apr 24, 2019
14 tasks
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we first started using Build Optimizer, we saw a lot of the savings were tied to using the Uglify/Terser
pure_gettersoption.This was intimately related with the structure and shape of the Angular codebase. The measurements we did at the time on angular.io showed a significant size reduction, from 1mb to about 600kb. Of these roughly 150kb were tied to using
pure_gettersif I remember correctly.Meanwhile the Angular codebase has changed significantly and I don't really see these savings anymore, so I don't think it makes sense to keep it on given that it is known to cause problems with some libraries.
Closes #9231, #11439, #12096, #12128.