Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular/cli): show analytics prompt when no global configuration file #14488

Merged
merged 3 commits into from
May 22, 2019

Conversation

clydin
Copy link
Member

@clydin clydin commented May 21, 2019

Fixes #14486

@clydin clydin added the target: patch This PR is targeted for the next patch release label May 21, 2019
@clydin clydin added this to the 8.0 milestone May 21, 2019
@alexeagle
Copy link
Contributor

no test?

@clydin
Copy link
Member Author

clydin commented May 22, 2019

Test added.

@clydin clydin force-pushed the fix-analytics-prompt branch from 2b355aa to 202fc57 Compare May 22, 2019 04:03
@mgechev mgechev merged commit eefa0bf into angular:master May 22, 2019
@clydin clydin deleted the fix-analytics-prompt branch May 22, 2019 10:09
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Analytics opt-in missing from RC4
4 participants