fix(@angular-devkit/build-angular): only add module script types to actual module scripts

[clydin]

ng serve was errantly adding a module type to custom script bundles. These scripts may contain ES5 and non-strict compatible code and can therefore not be marked as module scripts. ng build already correctly operates in this fashion.

Fixes #14952

[mgechev]

Third-party dependencies part of the main bundle might not be strict mode compatible either. My concern with such fix is that we introduce different behavior for the scripts based on how the application depends on them.

Looks like the behavior is already inconsistent given that we inject third-party scripts as modules in development but not in production.

[clydin]

It’s actually already different. Build operates this way and serve did as well up until 8.1. Serve behavior was changed due to a fix for the main bundles that unintentionally changed this as well.

This also allows people to use those third party libraries that would otherwise be unable to be included in the main application bundles, if needed. Without it, there would be no clean way to do so.

[alan-agius4]

Make sense to me. LGTM.

This does indeed align the behaviour between serve and build more.

[mgechev]

Sounds good

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}