Skip to content

feat(@angular-devkit/build-angular): collect test coverage from JSX/TSX files #15381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 21, 2019
Merged

feat(@angular-devkit/build-angular): collect test coverage from JSX/TSX files #15381

merged 1 commit into from
Aug 21, 2019

Conversation

AdamVig
Copy link
Contributor

@AdamVig AdamVig commented Aug 20, 2019

When testing React with Karma in a monorepo managed with Nx (built on top of the Angular CLI), I
found that TSX files were not showing up in test coverage reports. This change seems to fix that issue.

@mgechev mgechev added the needs: discussion On the agenda for team meeting to determine next steps label Aug 20, 2019
@AdamVig
Copy link
Contributor Author

AdamVig commented Aug 20, 2019

@mgechev If you have the time, would you mind explaining what about this pull request needs to be discussed?

I am under the impression that TSX is supported by the project based on this comment by filipesilva (from 2017, but I could not find anything more recent).

I need this change for a work project, so I am trying to determine if I should wait for it to get merged or if I should find a workaround.

@mgechev
Copy link
Member

mgechev commented Aug 20, 2019

Hey @AdamVig, since Angular does not use JSX supporting it extends our scope of work. During our triage meeting this/next Thursday we'll discuss how to proceed.

@mgechev mgechev removed the needs: discussion On the agenda for team meeting to determine next steps label Aug 20, 2019
@mgechev
Copy link
Member

mgechev commented Aug 20, 2019

Since we already have partial tsx support we can merge this fix and discuss separately whether we want to keep maintaining the feature.

Thanks for the contribution!

@clydin clydin added the target: major This PR is targeted for the next major release label Aug 21, 2019
@kyliau kyliau merged commit e7d99bc into angular:master Aug 21, 2019
@AdamVig AdamVig deleted the jsx-tsx-test-coverage branch August 21, 2019 17:36
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants