-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deploy command doc #15402
Add deploy command doc #15402
Conversation
|
||
When a project name is not supplied, the CLI will execute the `deploy` builder for the default project. | ||
The deploy builder defined in a deployment platform package is automatically added to a project's configuration when you add the package to the project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we update it to something like:
To use the ng deploy
command ng add
a package that implements deployment capabilities to your favorite platform. The ng-add
schematics of the package will automatically update your workspace configuration, adding a deployment CLI builder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also adding link to CLI Builder guide.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left few comments. Thanks for remembering to update the deploy-long.md
!
``` | ||
To use the `ng deploy` command, use `ng add` to add a package that implements deployment capabilities to your favorite platform. | ||
Adding the package automatically updates your workspace configuration, adding a deployment | ||
`CLI builder`(guide/cli-builder). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Users see deploy-long.md
when the run ng deploy --help
as well and this won't be rendered properly. Maybe we can drop it?
`CLI builder`(guide/cli-builder). | |
`CLI builder`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK -- but I think the long description only shows up in AIO, not in the help.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, feel free to ignore my comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last small comment. Otherwise, LGTM.
@kyliau the failure is because the CLI's size increased with the doc change. |
* docs: add deploy command doc * docs: fix json example * docs: add link to cli builder doc * docs: remove link * docs: restore link
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Adding some more detail to the API doc for the new
ng deploy
command.