fix(@schematics/angular): implements items type for guard schematic #15412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
reviewed
Aug 22, 2019
cexbrayat
force-pushed
the
fix/implements
branch
from
7f3fae9 to
29ab73d
Compare
alan-agius4
added
the
target: patch
Fixes the type of the items in the `schema.json` for `implements`, as `enum` alone is not picked up by the CLI. Also migrates the existing e2e test to `async/await` and adds another one with `implements` to avoid regressions.
alan-agius4
force-pushed
the
fix/implements
branch
from
29ab73d to
e8879ac
Compare
mgechev
pushed a commit
that referenced
this pull request
Aug 23, 2019
…15412) Fixes the type of the items in the `schema.json` for `implements`, as `enum` alone is not picked up by the CLI. Also migrates the existing e2e test to `async/await` and adds another one with `implements` to avoid regressions.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the type of the items in the
schema.jsonforimplements, asenumis not picked up by the CLI.Also migrates the existing e2e test to
async/awaitand adds another one withimplementsto avoid regressions.My previous PR #15313 fixed an issue in the guard schematic but introduced a regression (sorry!) as:
is not picked up by the CLI, so
--implementsends up not being recognized when running:The regression was released in CLI v8.3.0 stable (not in the next or rc releases).
If the issue is encountered, it can be easily worked around by using
--defaultsor manually picking the interface wanted in the prompt.