Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular-devkit/build-angular): remove prerelease @angular/compiler-cli peer dependency #15780

Merged
merged 1 commit into from
Oct 10, 2019

Conversation

clydin
Copy link
Member

@clydin clydin commented Oct 8, 2019

Prerelease versions of the @angular/compiler-cli package are not supported and should not be considered valid for a stable version of @angular-devkit/build-angular.

/cc @IgorMinar

@clydin clydin added the target: rc This PR is targeted for the next release-candidate label Oct 8, 2019
@clydin clydin force-pushed the compiler-cli-peer-dep branch from 1eeffcd to 4fbc06a Compare October 9, 2019 18:30
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I think we should also update

"@angular/compiler-cli": "^8.0.0-beta.0 || ^8.1.0-beta.0 || ^8.2.0-beta.0 || ^8.3.0-beta.0 || ^8.4.0-beta.0 || >=9.0.0-beta < 9",

…er-cli peer dependency

Prerelease versions of the package are not supported and should not be considered valid.
@clydin clydin force-pushed the compiler-cli-peer-dep branch from 4fbc06a to c793780 Compare October 10, 2019 02:05
@alan-agius4
Copy link
Collaborator

@clydin, can you rebase to make all checks green?

@clydin
Copy link
Member Author

clydin commented Oct 10, 2019

It was. There's an issue with the required check configuration on 8.3.x

@mgechev mgechev merged commit 100f1df into angular:8.3.x Oct 10, 2019
@clydin clydin deleted the compiler-cli-peer-dep branch October 10, 2019 21:37
This was referenced Oct 11, 2019
This was referenced Oct 17, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: rc This PR is targeted for the next release-candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants