Skip to content

Conversation

@clydin
Copy link
Member

@clydin clydin commented Dec 4, 2019

Originally intended to be part of #16332

Closes #16390

@clydin clydin added the target: patch This PR is targeted for the next patch release label Dec 4, 2019
@clydin clydin requested a review from alan-agius4 December 4, 2019 19:10
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. though this is also needs to be done in app-shell builder.

@kyliau kyliau merged commit 713f95d into angular:master Dec 9, 2019
@clydin clydin deleted the i18n-basehref-2 branch December 9, 2019 21:51
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Service worker failing with i18n because of absolute paths in ngsw-config.json

4 participants